feat: use icon for dictionary audio playback #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nepalingo with
|
| Latest commit: |
18aabf4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8a460d5.nepalingo.pages.dev |
| Branch Preview URL: | https://issue-230-dictionary-audio-i.nepalingo.pages.dev |
binamkayastha
commented
Oct 5, 2025
| const newAudio = new Audio(meaning.audio.uri); | ||
| setAudio(newAudio); | ||
| void newAudio.play(); | ||
| } |
Member
Author
There was a problem hiding this comment.
Looks like the same/similar code as the one in Card.tsx. Can we dry up the audio logic so it's not a repeat in this file and the Card file? Let me know if you have questions
binamkayastha
commented
Oct 29, 2025
|
|
||
| const useAudioPlayer = (audioUrl?: string) => { | ||
| const audioRef = useRef<HTMLAudioElement | null>(null); | ||
| const lastUrlRef = useRef<string | undefined>(audioUrl); |
Member
Author
There was a problem hiding this comment.
Can these be useStates instead of useRefs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230
Summary
Testing